[PATCH] D10854: Enable runtime unrolling with unroll pragma metadata

hfinkel at anl.gov hfinkel at anl.gov
Thu Jul 9 21:04:59 PDT 2015


hfinkel added a comment.

In http://reviews.llvm.org/D10854#202586, @meheff wrote:

> Hal,
>
> From your earlier comments it wasn't clear whether you were suggesting that
>  the front end should add unroll.full and unroll.disable.runtime metadata
>  with "#pragma unroll" OR if unroll.full metadata should imply no runtime
>  unrolling in the optimizer. I opted for the latter.  It seemed more natural
>  for the front-end just to do a straight-forward map of the directives to
>  metadata, and then the optimizer has the logic to properly deal with funny
>  cases like pragma unroll on a runtime trip count loop.


Yes, makes sense to me. Specifically requesting full unrolling on a loop with a non-static trip count does not make sense, and the optimizer should ignore it.

> Mark





http://reviews.llvm.org/D10854







More information about the llvm-commits mailing list