[PATCH] D10398: Add read_write_arg_mem attribute
hfinkel at anl.gov
hfinkel at anl.gov
Thu Jul 9 19:03:44 PDT 2015
hfinkel added inline comments.
================
Comment at: include/llvm/IR/CallSite.h:295
@@ +294,3 @@
+ /// on its arguments.
+ bool onlyAccessArgMemory() const {
+ CALLSITE_DELEGATE_GETTER(onlyAccessArgMemory());
----------------
I will not approve this patch without this change. All of the other functions read correctly by placing "it" in front of the function name:
"it does Not Access Memory"
"it does Not Return"
"it is NoInline"
and so this needs to be "it only Accesses ArgMemory" because "it only Access ArgMemory" is not grammatically correct.
Repository:
rL LLVM
http://reviews.llvm.org/D10398
More information about the llvm-commits
mailing list