[PATCH] D10714: Modify interleave diagnostics to clearly indicate why interleaving wasn't done.

[hfinkel at anl.gov]

hfinkel added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:1653
@@ +1652,3 @@
+
+    bool vecLoop = true, intLoop = true;
+    std::string vecDiagMsg, intDiagMsg;
----------------
These variable should start with a capital letter (per the coding conventions).

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:1665
@@ +1664,3 @@
+      DEBUG(dbgs() << "LV: Interleaving is not beneficial.\n");
+      intDiagMsg = "interleaving is not beneficial";
+      intLoop = false;
----------------
Same here (and below)... capital letters at the start of variable names.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:1674
@@ +1673,3 @@
+            << "LV: Interleaving is beneficial but is explicitly disabled.");
+      intDiagMsg = "interleaving is beneficial but is explicitly disabled or "
+                   "interleave count is set to 1";
----------------
Saying "is beneficial" seems a bit strong, especially considering that the user explicitly turned it off. We could say, "The cost model indicates that interleaving is beneficial, but...".


http://reviews.llvm.org/D10714