[PATCH] D10826: Fix AArch64 prologue for empty frame with dynamic allocas

Tim Northover t.p.northover at gmail.com
Thu Jul 9 16:25:59 PDT 2015


t.p.northover added inline comments.

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:361-362
@@ -357,4 +360,4 @@
+    assert(MF.getRegInfo().isPhysRegUsed(scratchSPReg) &&
            "No scratch register to align SP!");
-    scratchSPReg = AArch64::X9;
   }
 
----------------
eugenis wrote:
> t.p.northover wrote:
> > But X9 isn't callee-saved (AAPCS says it's temporary), so I don't think we need to worry about stack layouts: it's basically dead at this point.
> > 
> > Unless there's some assertion that *everything* is fixed by now?
> Well, all tests pass.
> Would you like me to switch to your variant?
It seems like the simplest variant so far. I'd say so, unless Kristof objects.


http://reviews.llvm.org/D10826







More information about the llvm-commits mailing list