[PATCH] D10972: Add missing builtins to altivec.h for ABI compliance (vol. 3)
Bill Schmidt
wschmidt at linux.vnet.ibm.com
Thu Jul 9 12:42:23 PDT 2015
wschmidt accepted this revision.
wschmidt added a comment.
This revision is now accepted and ready to land.
LGTM with additional commentary to explain what's going on. :) Thanks.
================
Comment at: lib/Basic/Targets.cpp:1341
@@ +1340,3 @@
+ }
+ Features[Name] = Enabled;
+}
----------------
After chatting with you on IRC, the above logic is correct but it is still pretty hard to understand. Please add a few more comments to explain the various scenarios.
Repository:
rL LLVM
http://reviews.llvm.org/D10972
More information about the llvm-commits
mailing list