[llvm] r241674 - [yaml2obj] Align section content using AddressAlign field's value

[Simon Atanasyan]

Fixed at r241835.

On Thu, Jul 9, 2015 at 7:22 PM, Simon Atanasyan <simon at atanasyan.com> wrote:
> Nice, I am going to commit the fix a bit later today. Thanks for the testing.
>
> On Thu, Jul 9, 2015 at 7:21 PM, Kuba Brecka <jbrecka at apple.com> wrote:
>> Yes, this seems to fix the issue.
>>
>> Kuba
>>
>>> On 09 Jul 2015, at 18:19, Simon Atanasyan <simon at atanasyan.com> wrote:
>>>
>>> Well, I found the second problem - .symtab section alignment. Please
>>> try new version of the patch.
>>>
>>> On Thu, Jul 9, 2015 at 6:35 PM, Kuba Brecka <jbrecka at apple.com> wrote:
>>>> Nope, doesn’t fix that, these two tests still fail the assert.
>>>>
>>>> Kuba
>>>>
>>>>> On 09 Jul 2015, at 17:20, Simon Atanasyan <simon at atanasyan.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I think the problem is in the missed section alignment in the tests.
>>>>> Default value for the AddressAlign filed is 0. But MIPS .rela.text
>>>>> sections uses 8-byte alignment and X86-64 .text section uses 4-byte
>>>>> alignment.
>>>>>
>>>>> Could you try the attached patch? Does it fix the problem?
>>>>>
>>>>> Simon
>>>>>
>>>>> On Thu, Jul 9, 2015 at 6:05 PM, Kuba Brecka <jbrecka at apple.com> wrote:
>>>>>> After this commit, one of our internal bots fails these two tests:
>>>>>>
>>>>>> Failing Tests (2):
>>>>>>  LLVM :: Object/Mips/elf-mips64-rel.yaml
>>>>>>  LLVM :: Object/yaml2obj-elf-symbol-basic.yaml
>>> <review.patch>
>>
>
>
>
> --
> Simon Atanasyan



-- 
Simon Atanasyan