[PATCH] D9918: Follow up to safe API patch

Jonathan Peyton jonathan.l.peyton at intel.com
Thu Jul 9 11:21:18 PDT 2015


This revision was automatically updated to reflect the committed changes.
Closed by commit rL241833: Follow up to safe API patch (authored by jlpeyton).

Changed prior to commit:
  http://reviews.llvm.org/D9918?vs=26265&id=29364#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D9918

Files:
  openmp/trunk/runtime/src/kmp_barrier.cpp
  openmp/trunk/runtime/src/kmp_safe_c_api.h

Index: openmp/trunk/runtime/src/kmp_safe_c_api.h
===================================================================
--- openmp/trunk/runtime/src/kmp_safe_c_api.h
+++ openmp/trunk/runtime/src/kmp_safe_c_api.h
@@ -23,9 +23,7 @@
 # define RSIZE_MAX_STR ( 4UL << 10 ) // 4KB
 
 // _malloca was suggested, but it is not a drop-in replacement for _alloca
-// TODO: test performance and replace with _alloca (as below)
-# define KMP_ALLOCA                  alloca
-//# define KMP_ALLOCA                  _alloca
+# define KMP_ALLOCA                  _alloca
 
 # define KMP_MEMCPY_S                memcpy_s
 # define KMP_SNPRINTF                sprintf_s
Index: openmp/trunk/runtime/src/kmp_barrier.cpp
===================================================================
--- openmp/trunk/runtime/src/kmp_barrier.cpp
+++ openmp/trunk/runtime/src/kmp_barrier.cpp
@@ -32,7 +32,7 @@
 #else
 #define ngo_load(src)            ((void)0)
 #define ngo_store_icvs(dst, src) copy_icvs((dst), (src))
-#define ngo_store_go(dst, src)   memcpy((dst), (src), CACHE_LINE)
+#define ngo_store_go(dst, src)   KMP_MEMCPY((dst), (src), CACHE_LINE)
 #define ngo_sync()               ((void)0)
 #endif /* KMP_MIC && USE_NGO_STORES */
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9918.29364.patch
Type: text/x-patch
Size: 1206 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150709/cd24ca57/attachment.bin>


More information about the llvm-commits mailing list