[PATCH] D11044: [ImplicitNullChecks] Be smarter in picking the memory op.

[Joseph Tremoulet]

JosephTremoulet added a comment.

LGTM, aside from the one question.


================
Comment at: lib/CodeGen/ImplicitNullChecks.cpp:274-278
@@ +273,7 @@
+
+    for (auto &MO : MI->defs())
+      RecordOperand(MO);
+
+    for (auto &IMO : MI->implicit_operands())
+      RecordOperand(IMO);
+  }
----------------
This may just be my ignorance of machine instruction modeling, but this reads like you're taking care to skip explicit use operands; why is that?


http://reviews.llvm.org/D11044