[PATCH] D9986: Refactor: Simplify boolean conditional return statements in lib/Target/SystemZ
Ulrich Weigand
ulrich.weigand at de.ibm.com
Thu Jul 9 10:13:15 PDT 2015
uweigand added a comment.
Some of these changes make sense to me, but a number of others don't appear to make the code more readable.
The latter are typically of the form:
if (cond1)
return false;
if (cond2)
return false;
...
if (condN)
return false;
return true;
In a sequence like this (which is written this way to be able to easily add/remove further conditions as appropriate, it doesn't really improve maintainability to just transform the *last* condition.
http://reviews.llvm.org/D9986
More information about the llvm-commits
mailing list