[PATCH] D9893: fix an invisible bug when combining repeated FP divisors

hfinkel at anl.gov hfinkel at anl.gov
Wed Jul 8 21:52:40 PDT 2015


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D9893#186998, @spatel wrote:

> Ping.
>
> If possible, I'd like to postpone the FMF question and just decide what the right solution for this bug is independently of FMF.


Okay, but please add a FIXME. Otheriwse, LGTM.

> Ie, is it necessary to use CombineTo here rather than RAUW? And is it wrong to return an empty SDValue() after we changed the DAG?





http://reviews.llvm.org/D9893







More information about the llvm-commits mailing list