[PATCH] D8413: Add getSizeInBits function to the APFloat class

[hfinkel at anl.gov]

hfinkel accepted this revision.
hfinkel added a comment.

LGTM.


================
Comment at: lib/Support/APFloat.cpp:3375
@@ +3374,3 @@
+unsigned APFloat::getSizeInBits(const fltSemantics &Sem)
+{
+  return Sem.sizeInBits;
----------------
This { should be on the previous line.

================
Comment at: lib/Support/APFloat.cpp:3377
@@ +3376,3 @@
+  return Sem.sizeInBits;
+}
+
----------------
>If I move it into the semantic then what should be the size value of calcSemantic in roundSignificandWithExponent? It isn't used by anybody (yet) but we still should give it a reasonable value.

I'd just leave it as 0 as you now have it. It also has 0 precision ;)



http://reviews.llvm.org/D8413