[PATCH] D11040: Make isLegalAddressingMode() taking DataLayout as an argument

Eric Christopher echristo at gmail.com
Wed Jul 8 16:08:13 PDT 2015


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

LGTM. One inline comment (that I've used in another review so I'll stop putting it in).

-eric


================
Comment at: include/llvm/Target/TargetLowering.h:1475-1476
@@ -1474,4 +1474,4 @@
   /// TODO: Remove default argument
-  virtual int getScalingFactorCost(const AddrMode &AM, Type *Ty,
-                                   unsigned AS = 0) const {
+  virtual int getScalingFactorCost(const AddrMode &AM, const DataLayout &DL,
+                                   Type *Ty, unsigned AS = 0) const {
     // Default: assume that any scaling factor used in a legal AM is free.
----------------
Consistency in parameter location...


http://reviews.llvm.org/D11040







More information about the llvm-commits mailing list