[llvm] r241663 - Revert r241621, "[CMake] Cleanup tools/CMakeLists.txt to take advantage of the auto-registration that was already partially working."

[NAKAMURA Takumi]

Chris,

2015-07-09 2:21 GMT+09:00 Chris Bieneman <beanz at apple.com>:
> I was unaware anyone was using that setting through the CMake command line, and there was a corresponding bug in my change that I can address. The other issue is that my patches renamed all the LLVM_EXTERNAL_*_* settings to LLVM_TOOL_*_* because they apply to both in and out of tree tools.
>
> Is there a reason you use this mechanism? For me to re-land my changes you’ll need to update your bots to use the new setting, or to not rely on this mechanism.

I am sorry that I didn't notice you supposed LLVM_EXTERNAL_*(s) were
trivial and I didn't explain since I supposed they were precious.
I am investigating bugs around there, later.

> Additionally, your bot doesn’t log its CMake invocation anywhere in the logs that I can see. Can you please update the bot so that it has its CMake invocation logged somewhere on every build so that issues like this can be triaged more easily? Without knowing that you were using the LLVM_EXTERNAL_CLANG_* flags there was no way for me to tell what was going wrong or to reproduce the issue.

Most of my builders are incremental and usually they don't put
configurations to the log. I know such a behavior is inconvenient.

It is doing reconfiguration in every build but it is prioritized
lower. http://bb.pgr.jp/builders/clang-3stage-x86_64-linux
Others are built from clean in every Morning. FYI for example,
  http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/37092
  http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/2192

FYI, Michael's r155654 was the last change for configuration.
I am not a fan of names, LLVM_TOOL_*. I think they are still external.

I won't stop cleanups. CMake scripts are messy.

...Takumi