[PATCH] D10961: Disable loop re-rotation for -Oz

[Michael Zolotukhin]

mzolotukhin added a subscriber: mzolotukhin.
mzolotukhin added a comment.

Hi Andrey,

The change looks good to me, but I think the test might be slightly improved. You could commit the patch with this addressed.

Thanks,
Michael


================
Comment at: Transforms/LoopRotate/oz-disable.ll:5-8
@@ +4,6 @@
+; Loop should be rotated for -Os but not for -Oz.
+; OS: icmp
+; OS: icmp
+; OZ: icmp
+; OZ-NOT: icmp
+
----------------
This check could be easily broken. A lot of stuff can happen to this loop when all passes are done, a simple example - the loop can be unrolled by 2, and then this check will fail.

I'd suggest we either check more specific regexps here, or just check debug output (add `-debug -debug-only=loop-rotate` and `REQUIRES: asserts`).


http://reviews.llvm.org/D10961