[PATCH] D11029: CFI: Get check-cfi passing on Windows.

[Alexey Samsonov]

samsonov added a comment.

Looks reasonable. I think it's fine to go in if you split ABI-specific code into two files.


================
Comment at: lib/ubsan/ubsan_diag.cc:169
@@ +168,3 @@
+      case Diag::AK_TypeName: {
+#if SANITIZER_WINDOWS
+        // The Windows implementation demangles names early.
----------------
Please use plain `if(SANITIZER_WINDOWS)` if possible.

================
Comment at: lib/ubsan/ubsan_type_hash.cc:256
@@ +255,3 @@
+
+#include <typeinfo>
+#include <windows.h>
----------------
I think we'd need to split this file into two - for Itanium and for MSVC.


http://reviews.llvm.org/D11029