[PATCH] D10937: [yaml2obj] Align section content using AddressAlign field's value

Sean Silva chisophugis at gmail.com
Tue Jul 7 20:53:00 PDT 2015


Two nits, otherwise LGTM.


================
Comment at: test/Object/yaml2obj-elf-alignment.yaml:1
@@ +1,2 @@
+# Check that yaml2obj takes in accoun section AddressAlign field.
+
----------------
Typo 'accoun'

================
Comment at: test/Object/yaml2obj-elf-section-basic.yaml:55
@@ -54,3 +54,3 @@
 # CHECK-NEXT:     Address: 0xCAFECAFE
-# CHECK-NEXT:     Offset: 0x1D0
+# CHECK-NEXT:     Offset: 0x1C2
 # CHECK-NEXT:     Size: 8
----------------
Can you commit a separate patch to just change these tests to regex match this field? I don't think the exact offset matters for what these are testing.


Repository:
  rL LLVM

http://reviews.llvm.org/D10937







More information about the llvm-commits mailing list