[PATCH] D11015: LLD: COFF: Check for incompatible machine types

[Peter Collingbourne]

pcc accepted this revision.

This revision is now accepted and ready to land.

LGTM with this change


================
Comment at: test/COFF/machine.test:21
@@ +20,3 @@
+# RUN: not lld -flavor link2 /entry:main /subsystem:console /machine:x86 \
+# RUN:   /out:%t.exe %p/Inputs/ret42.obj >& %t.log
+# RUN: FileCheck -check-prefix=INCOMPAT %s < %t.log
----------------
ruiu wrote:
> pcc wrote:
> > This test does not use `%t.obj`. Did you intend to add another test here for the non-`/machine` case?
> That's a mistake. I intended to use %t.obj instead of ret42.obj.
Can you add another test that shows that we diagnose machine type conflicts between files without a `/machine` flag?


http://reviews.llvm.org/D11015