[PATCH] D11003: Tolerate DWARF compile unit without filename.

Paul Robinson Paul_Robinson at playstation.sony.com
Tue Jul 7 15:46:52 PDT 2015


As a human I am probably most interested in the "primary" source file associated with an object file.  But as you say, primary-ness isn't relevant to how the file list is used within DWARF, or how debuggers would use it.  Thus, the filename from the comp unit would seem to be not hugely important.

The directory list is exactly for saving space.  It's not hard to come up with compilation units that have sourced in hundreds of include files, and the directory names they come from can be hundreds of characters long, but typically there are lots of include files in any given directory.  So, factoring out the directory names is typically a win.


http://reviews.llvm.org/D11003







More information about the llvm-commits mailing list