[PATCH] D10825: Improvement on computing edge probabilities when choosing the best successor in machine block placement.

[David]

Looks reasonable -- as the already laid-out inner loop should be treated as a 'collapsed' node.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:392
@@ +391,3 @@
+    // the inner loop.
+    auto SuccLoop = MLI->getLoopFor(Succ);
+    if (L && L != SuccLoop && !(SuccLoop && L->contains(SuccLoop))) {
----------------
I think it is better to provide a wrapper method to compute getSumForBlock (BB). In the wrapper method, exclude edge whose destination is in the same loop chain as BB.


http://reviews.llvm.org/D10825