[PATCH] D10656: LLVM OpenMP CMake Overhaul

[Ed Maste]

================
Comment at: runtime/cmake/LibompMicroTests.cmake:18
@@ +17,3 @@
+#    - Program dependencies: gcc or g++, grep, bourne shell
+#    - Available for all Linux,Mac,Windows builds.  Not available on Intel(R) MIC Architecture builds.
+# (2) test-relo
----------------
+FreeBSD

================
Comment at: runtime/cmake/LibompMicroTests.cmake:23
@@ +22,3 @@
+#    - Program dependencies: readelf, grep, bourne shell
+#    - Available for Linux, Intel(R) MIC Architecture dynamic library builds. Not available otherwise.
+# (3) test-execstack 
----------------
+FreeBSD

================
Comment at: runtime/cmake/LibompMicroTests.cmake:28
@@ +27,3 @@
+#    - Program dependencies: perl, readelf
+#    - Available for Linux dynamic library builds. Not available otherwise.
+# (4) test-instr (Intel(R) MIC Architecutre only) 
----------------
+FreeBSD
```
feynman% ninja libomp-test-execstack   
[1/1] Generating test-execstack/.success
```

================
Comment at: runtime/cmake/LibompMicroTests.cmake:33
@@ +32,3 @@
+#    - Program dependencies: perl, objdump 
+#    - Available for Intel(R) MIC Architecture builds. Not available otherwise.
+# (5) test-deps      
----------------
Note that the failure message when I try to run it seems to contradict this statement:
```
check-instruction-set.pl: (x) Only works on lin_32 and lin_mic platforms.
```

================
Comment at: runtime/cmake/LibompMicroTests.cmake:38
@@ +37,3 @@
+#    - Program dependencies: perl, (linux)readelf, (mac)otool[64], (windows)link.exe
+#    - Available for Linux,Mac,Windows, Intel(R) MIC Architecture dynamic builds and Windows 
+#      static builds. Not available otherwise.
----------------
+FreeBSD
```
[1/1] Generating test-deps/.success
check-depends.pl: (i) Dependencies:
check-depends.pl: (i)     libc.so.7
check-depends.pl: (i)     libthr.so.3
```

================
Comment at: runtime/src/CMakeLists.txt:104-106
@@ +103,5 @@
+        # Unix specific files
+        libomp_append(LIBOMP_CFILES z_Linux_util.c)
+        libomp_append(LIBOMP_CFILES kmp_gsupport.c)
+        libomp_append(LIBOMP_ASMFILES z_Linux_asm.s) # Unix assembly file
+    endif()
----------------
Nitpick, should these be `z_Unix_util.c` and `z_Unix_asm.s`?


Repository:
  rL LLVM

http://reviews.llvm.org/D10656