[PATCH] D10656: LLVM OpenMP CMake Overhaul

[Peyton, Jonathan L]

I can get rid of the timestamps easily in the kmp_i18_n* files and the kmp_version.c file (which uses __TIME__ and __DATE__ macros now) can probably be easily deleted as well but involves changing the source code a little.  I will do this in a different patch though as I want this patch to be exclusively CMake.

-- Johnny

-----Original Message-----
From: Jack Howarth [mailto:howarth.mailing.lists at apple.com] 
Sent: Saturday, July 4, 2015 5:27 PM
To: Peyton, Jonathan L; chandlerc at gmail.com
Cc: Cownie, James H; emaste at freebsd.org; howarth.mailing.lists at apple.com; cbergstrom at pathscale.com; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] D10656: LLVM OpenMP CMake Overhaul

FYI, I have built current openmp trunk with the the third permutation of the cmake overhaul applied as part of an in-tree llvm/clang/compiler-rt/libc++/polly cmake build using a 3-stage bootstrap with stage2/stage3 comparison of binaries on x86_64-apple-darwin13/14/15. The only minor nit I found was that three files should differences between stage2/stage3 due to the timestamps added by

  -- stage2/projects/openmp/runtime/src/kmp_i18n_default.inc	2015-07-04 17:04:13.000000000 -0400
  +++ stage3/projects/openmp/runtime/src/kmp_i18n_default.inc	2015-07-04 17:28:37.000000000 -0400
  @@ -1,5 +1,5 @@
   // Do not edit this file! //
  -// The file was generated from en_US.txt by message-converter.pl on Sat Jul  4 17:04:13 2015. //
  +// The file was generated from en_US.txt by message-converter.pl on Sat Jul  4 17:28:37 2015. //
   
   static char const *
  --- stage2/projects/openmp/runtime/src/kmp_i18n_id.inc	2015-07-04 17:04:13.000000000 -0400
  +++ stage3/projects/openmp/runtime/src/kmp_i18n_id.inc	2015-07-04 17:28:37.000000000 -0400
  @@ -1,5 +1,5 @@
   // Do not edit this file! //
  -// The file was generated from en_US.txt by message-converter.pl on Sat Jul  4 17:04:13 2015. //
  +// The file was generated from en_US.txt by message-converter.pl on Sat Jul  4 17:28:37 2015. //
   
   enum kmp_i18n_id {
   

and projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_version.c.o which I assume is related to those two diffs. Would it be possible to modify message-converter.pl so that it doesn't emit the time-stamp?


Repository:
  rL LLVM

http://reviews.llvm.org/D10656