[PATCH] D10924: [asan] Add OS X 10.11's new dyld interposition support

Alexander Potapenko glider at google.com
Tue Jul 7 02:27:08 PDT 2015


LGTM, sorry for the delay.


================
Comment at: lib/asan/asan_mac.cc:104
@@ +103,3 @@
+// If running on OS X 10.11+ or iOS 9.0+, dyld will interpose even if
+// DYLD_INSERT_LIBRARIES is not set.
+
----------------
This is great.

================
Comment at: test/asan/TestCases/Darwin/dyld_insert_libraries_reexec.cc:15
@@ +14,3 @@
+
+// RUN: IS_OSX_10_11_OR_HIGHER=$([ `sw_vers -productVersion | cut -d'.' -f2` -lt 11 ]; echo $?)
+
----------------
Don't we run Darwin tests on the iOS simulator?


http://reviews.llvm.org/D10924







More information about the llvm-commits mailing list