[PATCH] D10977: Allow {e, r}bp as the target of {read, write}_register.

hfinkel at anl.gov hfinkel at anl.gov
Mon Jul 6 20:23:10 PDT 2015


hfinkel added a subscriber: hfinkel.

You're going to need something in between this patch and the original one. The fundamental issue here is that asserts are not appropriate for user-facing code. If the user requests a read of 'ebp' in a function in which ebp is allocatable, then (at least in a +Asserts build) the verifier is likely to complain about a read of an undefined register. It is important that we prevent this from happening.

However, when this happens, we should try to give a slightly-more-informative error than, "Invalid register name global variable", because that's misleading. Please make it say something accurate for this case.


http://reviews.llvm.org/D10977







More information about the llvm-commits mailing list