[PATCH] D10904: Fix Integer Division Expansion special case of divide by 1

Matthias Braun matze at braunis.de
Mon Jul 6 13:08:40 PDT 2015


MatzeB added subscribers: milseman, MatzeB.

Hi Aditya,

please upload a patch with full context next time (see http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). We also try to create test cases when we fix a bug.

The change itself looks okay to me, but I'd wait for a LGTM from the original author (milseman) as I don't understand the motivation of using CTLZ there instead of just comparing the dividend and divisor so I may be missing something.


Repository:
  rL LLVM

http://reviews.llvm.org/D10904







More information about the llvm-commits mailing list