[PATCH] D10593: [X86][AVX] Add support for shuffle decoding of vperm2f128/vperm2i128 with zero'd lanes
Sanjay Patel
spatel at rotateright.com
Mon Jul 6 08:46:12 PDT 2015
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:4455
@@ -4453,1 +4454,3 @@
if (Mask.empty()) return false;
+ // Mask only contains -ve index if an element is zero.
+ if (std::any_of(Mask.begin(), Mask.end(), [](int M){ return M < 0; }))
----------------
-ve ?
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:4456
@@ +4455,3 @@
+ // Mask only contains -ve index if an element is zero.
+ if (std::any_of(Mask.begin(), Mask.end(), [](int M){ return M < 0; }))
+ return false;
----------------
Should this check be:
M == SM_SentinelZero
Repository:
rL LLVM
http://reviews.llvm.org/D10593
More information about the llvm-commits
mailing list