[PATCH] D10687: [Mips] Add support for MCJIT for MIPS32r6

[Vladimir Radosavljevic]

vradosavljevic marked 2 inline comments as done.

================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:522
@@ +521,3 @@
+    Insn &= 0xffff0000;
+    Insn |= ((Value - FinalAddress) >> 2) & 0xffff;
+    writeBytesUnaligned(Insn, TargetPtr, 4);
----------------
dsanders wrote:
> Are you sure about the '>> 2'? This isn't mentioned in the documentation I'm reading and it isn't present on the PCLO16. I suspect it's a copy/paste error from the *_S2 relocs below
Yes, I'm sure that R_MIPS_PC16 relocation has '>> 2'. You can check that in lld or bfd. I don't know why that isn't documented.


Repository:
  rL LLVM

http://reviews.llvm.org/D10687