[PATCH] D10940: COFF: Numerous fixes for interaction between LTO and weak externals.
Peter Collingbourne
peter at pcc.me.uk
Fri Jul 3 22:29:33 PDT 2015
================
Comment at: COFF/Symbols.cpp:239
@@ -238,1 +238,3 @@
+Defined *Undefined::resolveWeakAlias() {
+ // A weak alias may be a weak alias to another symbol, so check recursively.
----------------
ruiu wrote:
> I'd name getWeakAlias.
Done
================
Comment at: COFF/Symbols.cpp:244
@@ +243,3 @@
+ return D;
+ }
+ return nullptr;
----------------
ruiu wrote:
> You can remove this brace.
Done
Repository:
rL LLVM
http://reviews.llvm.org/D10940
More information about the llvm-commits
mailing list