[Patch][LoopVectorize] Renaming and Diagnostics for Loop Interleaving

[Tyler Nowicki]

Hi,

Could I get a review of these patches?

Thanks,

Tyler

> On Jun 24, 2015, at 4:23 PM, Tyler Nowicki <tnowicki at apple.com> wrote:
> 
> Hi Hal,
> 
> Sorry about the 80 column limit. I put the main patch on phabricator, sorry if you received some spam related to this. I am not very familiar with it.
> 
> http://reviews.llvm.org/D10714 <http://reviews.llvm.org/D10714>
> 
> Here is the renaming patch again with the column limit fixed.
> 
> Thanks,
> 
> Tyler
> 
> <0002-Rename-some-uses-of-unroll-to-interleave.patch>
> 
>> On Jun 22, 2015, at 5:18 PM, Hal Finkel <hfinkel at anl.gov <mailto:hfinkel at anl.gov>> wrote:
>> 
>> Hi Tyler,
>> 
>> Please upload these patches to phabricator for review. I'd find that much easier. Also, you have many lines in these patches that violate the 80 column limit.
>> 
>> Thanks again,
>> Hal
>> 
>> ----- Original Message -----
>>> From: "Tyler Nowicki" <tnowicki at apple.com <mailto:tnowicki at apple.com>>
>>> To: llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>> Sent: Monday, June 22, 2015 12:52:34 PM
>>> Subject: Re: [Patch][LoopVectorize] Renaming and Diagnostics for Loop	Interleaving
>>> 
>>> Hi,
>>> 
>>> I would appreciate a review of these patches.
>>> 
>>> Thanks,
>>> 
>>> Tyler
>>> 
>>>> On Jun 15, 2015, at 6:30 PM, Tyler Nowicki <tnowicki at apple.com <mailto:tnowicki at apple.com>>
>>>> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> Here is a renaming patch for names like unroll factor to names like
>>>> interleave count and a patch that improves the diagnostics for
>>>> interleaving so the user knows when they have explicitly disabled
>>>> interleaving and when it is not profitable. Includes test cases.
>>>> 
>>>> Any comments are much appreciated!
>>>> 
>>>> Tyler
>>>> 
>>>> <0002-Rename-some-uses-of-unroll-to-interleave.patch><0003-Modify-diagnostic-messages-to-clearly-indicate-the-w.patch>_______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>> 
>> 
>> -- 
>> Hal Finkel
>> Assistant Computational Scientist
>> Leadership Computing Facility
>> Argonne National Laboratory
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150702/8fda0d19/attachment.html>