r240176 caused a regression in reading MIPS elf files.

[Daniel Sanders]

> Sorry, but what issues did it cause? 32 bits mips uses REL instead of RELA.

I don't know about the issues caused (yet?) but I should mention that the visitELF_MIPS_32() mentioned in Amjad's patch handles the R_MIPS_32 reloc for both the REL and RELA cases. It's not referring to 32-bit Mips.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Rafael Espíndola
> Sent: 02 July 2015 13:31
> To: Aboud, Amjad
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: r240176 caused a regression in reading MIPS elf files.
> 
> On 1 July 2015 at 15:02, Aboud, Amjad <amjad.aboud at intel.com> wrote:
> > Hi Rafael,
> >
> > I just noticed that your commit in revision 240176 caused a regression in
> reading elf file for MIPS architecture.
> > It seems a copy paste issue, please see attach patch with the proposed fix.
> >
> > If you agree, please can you take care of the issue?
> 
> Sorry, but what issues did it cause? 32 bits mips uses REL instead of RELA.
> 
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits