[PATCH] AArch64: Use CMP;CCMP sequences for and/or/setcc trees.

Renato Golin renato.golin at linaro.org
Thu Jul 2 02:55:40 PDT 2015


Hi Matthias,

I couldn't find anything terribly wrong with it, but then again, I'm not terribly familiar with CCMP and others. Apart from the goto usage that can easily be replaced by a local flag, I have no reservations. But please wait for Tim, James or someone else with more knowledge on AArch64 to approve.

cheers,
--renato


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:1480
@@ +1479,3 @@
+        AArch64CC = changeIntCCToAArch64CC(CC);
+        goto CreateCCNode;
+      }
----------------
I don't think this is a really good use case for a goto.

http://reviews.llvm.org/D10579

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list