[PATCH] [GraphWriter] Don't wait on xdg-open when not on Apple
Charlie Turner
charlie.turner at arm.com
Thu Jul 2 02:39:24 PDT 2015
> As we are on the topic: I think the current approach of having llvm
> spawn the viewer and wait/not wait for it should be changed: I'd
> really prefer llvm just writing a bunch of .dot files to the current
> directory (or /tmp) giving them some sensible names+numbers and maybe
> print those names.
>
> This would avoid llvm having to find and launch the correct viewer. In
> my experience I also often have cases where n graphs are generated but
> I am only interested in one of them which forces me to close n-1 graph
> viewers.
I suppose you mean the same thing as the -dot-* options to the `opt`
tool? I agree that would be handy extension to `llc` for the
visualisation tools too.
Landed r241250 in meantime. Thank you for reviewing my patch!
Kind regards, Charlie.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10873
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list