[llvm] r241165 - [SDAG] Give InstrEmitter hidden visibility

Benjamin Kramer benny.kra at gmail.com
Wed Jul 1 16:03:14 PDT 2015


> On 02.07.2015, at 00:28, Sean Silva <chisophugis at gmail.com> wrote:
> 
> What does this actually buy us? Better link times? Less probability of namespace collisions?

A couple of kilobytes less in binary size and possibly more efficient code when LLVM is built as PIC.

- Ben 

> 
> On Wed, Jul 1, 2015 at 7:55 AM, Benjamin Kramer <benny.kra at googlemail.com> wrote:
> Author: d0k
> Date: Wed Jul  1 09:55:10 2015
> New Revision: 241165
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=241165&view=rev
> Log:
> [SDAG] Give InstrEmitter hidden visibility
> 
> NFC.
> 
> Modified:
>     llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h
> 
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h?rev=241165&r1=241164&r2=241165&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h Wed Jul  1 09:55:10 2015
> @@ -26,7 +26,7 @@ class MachineInstrBuilder;
>  class MCInstrDesc;
>  class SDDbgValue;
> 
> -class InstrEmitter {
> +class LLVM_LIBRARY_VISIBILITY InstrEmitter {
>    MachineFunction *MF;
>    MachineRegisterInfo *MRI;
>    const TargetInstrInfo *TII;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 





More information about the llvm-commits mailing list