[PATCH] ubsan: Port runtime library to (32- and 64-bit) Windows.
Alexey Samsonov
vonosmas at gmail.com
Wed Jul 1 11:19:50 PDT 2015
LGTM
================
Comment at: lib/ubsan/ubsan_platform.h:20
@@ -20,1 +19,3 @@
+ defined(__aarch64__) || defined(__mips__) || defined(__powerpc64__)) || \
+ defined(_WIN32)
# define CAN_SANITIZE_UB 1
----------------
Alright... but the boolean expression is really hard to parse. Just move _WIN32 to another branch?
#if defined(_WIN32)
# define CAN_SANITIZE_UB 1
#elif (defined(__linux__) || ....
# define CAN_SANITIZE_UB 1
#else
# define CAN_SANITIZE_UB 0
#endif
http://reviews.llvm.org/D10856
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list