[PATCH] [GraphWriter] Don't wait on xdg-open when not on Apple
Matthias Braun
matze at braunis.de
Wed Jul 1 11:05:43 PDT 2015
The patch itself LGTM.
As we are on the topic: I think the current approach of having llvm spawn the viewer and wait/not wait for it should be changed: I'd really prefer llvm just writing a bunch of .dot files to the current directory (or /tmp) giving them some sensible names+numbers and maybe print those names.
This would avoid llvm having to find and launch the correct viewer. In my experience I also often have cases where n graphs are generated but I am only interested in one of them which forces me to close n-1 graph viewers.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10873
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list