[PATCH] Extending Vector GetElementPtr - please review

[Demikhovsky, Elena]

Renato,
thank you, I'll fix.

Hal, do you have more comments for this patch?

-  Elena


-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: Wednesday, July 01, 2015 11:45
To: Demikhovsky, Elena; nrotem at apple.com; aschwaighofer at apple.com; mzolotukhin at apple.com; dblaikie at gmail.com; hfinkel at anl.gov
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Extending Vector GetElementPtr - please review

In http://reviews.llvm.org/D10496#197665, @delena wrote:

> Please see the start of discussion: http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-March/082921.html
>  And the end agreement: http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-March/082989.html


Ok, I missed that discussion, sorry. I agree it's justifiable.

The patch looks good to me, apart from some small comments. But I'd like Hal to give the final approval.

cheers,
--renato


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2792
@@ -2781,2 +2791,3 @@
 
       // If this is a constant subscript, handle it quickly.
+      const auto *CI = dyn_cast<ConstantInt>(Idx);
----------------
This comment is outdated, needs to be moved down.

================
Comment at: lib/IR/Verifier.cpp:2565
@@ -2567,3 +2564,3 @@
     }
   }
   visitInstruction(GEP);
----------------
I think you should add an extra assert that the scalar types, if any, possibly must be pointers of the same family (int / float), but not necessarily the same width.

http://reviews.llvm.org/D10496

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.