[PATCH] Use function attribute "trap-func-name" and remove TargetOptions::TrapFuncName

Akira Hatanaka ahatanak at gmail.com
Tue Jun 30 18:35:27 PDT 2015


Here is my new patch. Sorry for asking for a review again.

- Changed normal isel and fast isel to read the "trap-func-name" attached to the call-site.

- Added new functions that are needed to access and modify string attributes attached to CallInst.

- Made changes to setFunctionAttributes that are needed to override "trap-func-name" in the IR via command line option "trap-func". If the command line option is used, iterate over all instructions in the function and rewrite the function attribute attached to the call sites. Alternatively, I think we can iterate over the list of AttributeSetImpl owned by LLVMContextImpl if visiting all instructions is too expensive.


http://reviews.llvm.org/D10832

Files:
  include/llvm/CodeGen/CommandFlags.h
  include/llvm/IR/Instructions.h
  include/llvm/Target/TargetOptions.h
  lib/CodeGen/SelectionDAG/FastISel.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/TargetOptionsImpl.cpp
  lib/IR/Instructions.cpp
  test/CodeGen/ARM/fnattr-trap.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10832.28834.patch
Type: text/x-patch
Size: 8838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150701/effc3317/attachment.bin>


More information about the llvm-commits mailing list