[PATCH] [NVPTX] cleanups and refacotring in NVPTXFrameLowering.cpp

[Jingyue Wu]

Hi wengxt,

NFC

http://reviews.llvm.org/D10849

Files:
  lib/Target/NVPTX/NVPTXFrameLowering.cpp

Index: lib/Target/NVPTX/NVPTXFrameLowering.cpp
===================================================================
--- lib/Target/NVPTX/NVPTXFrameLowering.cpp
+++ lib/Target/NVPTX/NVPTXFrameLowering.cpp
@@ -35,41 +35,33 @@
                                       MachineBasicBlock &MBB) const {
   if (MF.getFrameInfo()->hasStackObjects()) {
     assert(&MF.front() == &MBB && "Shrink-wrapping not yet supported");
-    // Insert "mov.u32 %SP, %Depot"
     MachineInstr *MI = MBB.begin();
     MachineRegisterInfo &MR = MF.getRegInfo();
 
     // This instruction really occurs before first instruction
     // in the BB, so giving it no debug location.
     DebugLoc dl = DebugLoc();
 
-    // mov %SPL, %depot;
-    // cvta.local %SP, %SPL;
-    if (static_cast<const NVPTXTargetMachine &>(MF.getTarget()).is64Bit()) {
-      // Check if %SP is actually used
-      if (!MR.use_empty(NVPTX::VRFrame)) {
-        MI = BuildMI(MBB, MI, dl, MF.getSubtarget().getInstrInfo()->get(
-                                      NVPTX::cvta_local_yes_64),
-                     NVPTX::VRFrame)
-                 .addReg(NVPTX::VRFrameLocal);
-      }
-      BuildMI(MBB, MI, dl,
-              MF.getSubtarget().getInstrInfo()->get(NVPTX::MOV_DEPOT_ADDR_64),
-              NVPTX::VRFrameLocal)
-          .addImm(MF.getFunctionNumber());
-    } else {
-      // Check if %SP is actually used
-      if (!MR.use_empty(NVPTX::VRFrame)) {
-        MI = BuildMI(MBB, MI, dl, MF.getSubtarget().getInstrInfo()->get(
-                                      NVPTX::cvta_local_yes),
-                     NVPTX::VRFrame)
-                 .addReg(NVPTX::VRFrameLocal);
-      }
-      BuildMI(MBB, MI, dl,
-              MF.getSubtarget().getInstrInfo()->get(NVPTX::MOV_DEPOT_ADDR),
-              NVPTX::VRFrameLocal)
-          .addImm(MF.getFunctionNumber());
+    // Emits
+    //   mov %SPL, %depot;
+    //   cvta.local %SP, %SPL;
+    // for local address accesses in MF.
+    bool Is64Bit =
+        static_cast<const NVPTXTargetMachine &>(MF.getTarget()).is64Bit();
+    unsigned CvtaLocalOpcode =
+        (Is64Bit ? NVPTX::cvta_local_yes_64 : NVPTX::cvta_local_yes);
+    unsigned MovDepotOpcode =
+        (Is64Bit ? NVPTX::MOV_DEPOT_ADDR_64 : NVPTX::MOV_DEPOT_ADDR);
+    if (!MR.use_empty(NVPTX::VRFrame)) {
+      // If %SP is not used, do not bother emitting "cvta.local %SP, %SPL".
+      MI = BuildMI(MBB, MI, dl,
+                   MF.getSubtarget().getInstrInfo()->get(CvtaLocalOpcode),
+                   NVPTX::VRFrame)
+               .addReg(NVPTX::VRFrameLocal);
     }
+    BuildMI(MBB, MI, dl, MF.getSubtarget().getInstrInfo()->get(MovDepotOpcode),
+            NVPTX::VRFrameLocal)
+        .addImm(MF.getFunctionNumber());
   }
 }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10849.28813.patch
Type: text/x-patch
Size: 2743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150630/58f3bc19/attachment.bin>