[llvm] r241062 - [mips] [IAS] Make .module directives change AssemblerOptions->front().
Toma Tabacu
toma.tabacu at gmail.com
Tue Jun 30 05:41:34 PDT 2015
Author: tomatabacu
Date: Tue Jun 30 07:41:33 2015
New Revision: 241062
URL: http://llvm.org/viewvc/llvm-project?rev=241062&view=rev
Log:
[mips] [IAS] Make .module directives change AssemblerOptions->front().
Differential Revision: http://reviews.llvm.org/D10643
Added:
llvm/trunk/test/MC/Mips/update-module-level-options.s
Modified:
llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
Modified: llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp?rev=241062&r1=241061&r2=241062&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp Tue Jun 30 07:41:33 2015
@@ -361,6 +361,16 @@ class MipsAsmParser : public MCTargetAsm
}
}
+ void setModuleFeatureBits(uint64_t Feature, StringRef FeatureString) {
+ setFeatureBits(Feature, FeatureString);
+ AssemblerOptions.front()->setFeatures(STI.getFeatureBits());
+ }
+
+ void clearModuleFeatureBits(uint64_t Feature, StringRef FeatureString) {
+ clearFeatureBits(Feature, FeatureString);
+ AssemblerOptions.front()->setFeatures(STI.getFeatureBits());
+ }
+
public:
enum MipsMatchResultTy {
Match_RequiresDifferentSrcAndDst = FIRST_TARGET_MATCH_RESULT_TY
@@ -4711,7 +4721,7 @@ bool MipsAsmParser::parseDirectiveModule
}
if (Option == "oddspreg") {
- clearFeatureBits(Mips::FeatureNoOddSPReg, "nooddspreg");
+ clearModuleFeatureBits(Mips::FeatureNoOddSPReg, "nooddspreg");
// Synchronize the abiflags information with the FeatureBits information we
// changed above.
@@ -4735,7 +4745,7 @@ bool MipsAsmParser::parseDirectiveModule
return false;
}
- setFeatureBits(Mips::FeatureNoOddSPReg, "nooddspreg");
+ setModuleFeatureBits(Mips::FeatureNoOddSPReg, "nooddspreg");
// Synchronize the abiflags information with the FeatureBits information we
// changed above.
@@ -4800,6 +4810,7 @@ bool MipsAsmParser::parseFpABIValue(Mips
StringRef Directive) {
MCAsmParser &Parser = getParser();
MCAsmLexer &Lexer = getLexer();
+ bool ModuleLevelOptions = Directive == ".module";
if (Lexer.is(AsmToken::Identifier)) {
StringRef Value = Parser.getTok().getString();
@@ -4816,8 +4827,13 @@ bool MipsAsmParser::parseFpABIValue(Mips
}
FpABI = MipsABIFlagsSection::FpABIKind::XX;
- setFeatureBits(Mips::FeatureFPXX, "fpxx");
- clearFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ if (ModuleLevelOptions) {
+ setModuleFeatureBits(Mips::FeatureFPXX, "fpxx");
+ clearModuleFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ } else {
+ setFeatureBits(Mips::FeatureFPXX, "fpxx");
+ clearFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ }
return true;
}
@@ -4837,12 +4853,22 @@ bool MipsAsmParser::parseFpABIValue(Mips
}
FpABI = MipsABIFlagsSection::FpABIKind::S32;
- clearFeatureBits(Mips::FeatureFPXX, "fpxx");
- clearFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ if (ModuleLevelOptions) {
+ clearModuleFeatureBits(Mips::FeatureFPXX, "fpxx");
+ clearModuleFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ } else {
+ clearFeatureBits(Mips::FeatureFPXX, "fpxx");
+ clearFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ }
} else {
FpABI = MipsABIFlagsSection::FpABIKind::S64;
- clearFeatureBits(Mips::FeatureFPXX, "fpxx");
- setFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ if (ModuleLevelOptions) {
+ clearModuleFeatureBits(Mips::FeatureFPXX, "fpxx");
+ setModuleFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ } else {
+ clearFeatureBits(Mips::FeatureFPXX, "fpxx");
+ setFeatureBits(Mips::FeatureFP64Bit, "fp64");
+ }
}
return true;
Added: llvm/trunk/test/MC/Mips/update-module-level-options.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Mips/update-module-level-options.s?rev=241062&view=auto
==============================================================================
--- llvm/trunk/test/MC/Mips/update-module-level-options.s (added)
+++ llvm/trunk/test/MC/Mips/update-module-level-options.s Tue Jun 30 07:41:33 2015
@@ -0,0 +1,14 @@
+# RUN: not llvm-mc %s -arch=mips -mcpu=mips32 -mattr=+fp64,-nooddspreg 2>&1 | \
+# RUN: FileCheck %s
+
+ .module nooddspreg
+ add.s $f1, $f2, $f4
+# CHECK: :[[@LINE-1]]:9: error: -mno-odd-spreg prohibits the use of odd FPU registers
+
+ .set oddspreg
+ add.s $f1, $f2, $f4
+# CHECK-NOT: :[[@LINE-1]]:{{[0-9]+}}: error: -mno-odd-spreg prohibits the use of odd FPU registers
+
+ .set mips0
+ add.s $f1, $f2, $f4
+# CHECK: :[[@LINE-1]]:9: error: -mno-odd-spreg prohibits the use of odd FPU registers
More information about the llvm-commits
mailing list