[PATCH] Fix for 9807. Avoid over-relaxation of 8-bit immediates in integer arithmetic instructions.

Sean Silva chisophugis at gmail.com
Mon Jun 29 19:25:52 PDT 2015


On Mon, Jun 29, 2015 at 3:13 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 29 June 2015 at 18:09, David Kreitzer <david.l.kreitzer at intel.com>
> wrote:
> > Fixed the style issue pointed out by David and a few others with braces,
> indentation, and an empty comment line. (Old habits die hard.)
> >
> > Rafael, I'm happy to change the 2 new tests to use llvm-objdump instead
> of llvm-readobj if you think that is preferred. I just want to point out
> that llvm-readobj is used more predominantly in test/MC/ELF:
> >
> > bash-4.3$ grep llvm-readobj *.s | wc -l
> > 120
> > bash-4.3$ grep llvm-objdump *.s | wc -l
> > 7
> >
>
> llvm-readobj is perfect for testing the structure of the file
> (section, symbols, relocations).
>
> In this particular case llvm-objdump has the big advantage that it can
> disassemble and prints one instruction per line.
>

The downside is that it requires X86 target, which I'm not sure if
test/MC/ELF already has an appropriate lit requirement for.

-- Sean Silva


>
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150629/10fb182c/attachment.html>


More information about the llvm-commits mailing list