[llvm] r240939 - Remove Elf_Sym_Iter.

[Sean Silva]

On Mon, Jun 29, 2015 at 12:34 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 29 June 2015 at 14:57, Michael Spencer <bigcheesegs at gmail.com> wrote:
> > This change violates the ELF spec. You're ignoring the sh_entsize
> > field while iterating over symbols. I'm fine with removing the
> > "dynamic" bit and fixing the other APIs.
>
> How so?
>
> The spec defines the content of those sections. We should report an
> error if sh_entsize is wrong.
>

IIRC you are supposed to be able to set an entsize larger than the actual
struct size. Can't find a citation though.

-- Sean Silva


>
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150629/8e404509/attachment.html>