[PATCH] Object/COFF: Define coff_symbol_generic

David Majnemer david.majnemer at gmail.com
Mon Jun 29 16:40:56 PDT 2015


================
Comment at: lib/Object/COFFObjectFile.cpp:867-868
@@ -866,1 +866,4 @@
 
+std::error_code COFFObjectFile::getSymbolName(const coff_symbol_generic *Symbol,
+                                              StringRef &Res) const {
+  COFFSymbolRef S(reinterpret_cast<const coff_symbol16 *>(Symbol));
----------------
I think it would make more sense to change the original `getSymbolName` implementation's Symbol to `coff_symbol_generic` and then have an overload for `COFFSymbolRef`.

http://reviews.llvm.org/D10819

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list