[PATCH] Fix for 9807. Avoid over-relaxation of 8-bit immediates in integer arithmetic instructions.

David Kreitzer david.l.kreitzer at intel.com
Mon Jun 29 15:09:41 PDT 2015


Fixed the style issue pointed out by David and a few others with braces, indentation, and an empty comment line. (Old habits die hard.)

Rafael, I'm happy to change the 2 new tests to use llvm-objdump instead of llvm-readobj if you think that is preferred. I just want to point out that llvm-readobj is used more predominantly in test/MC/ELF:

bash-4.3$ grep llvm-readobj *.s | wc -l
120
bash-4.3$ grep llvm-objdump *.s | wc -l
7

Thanks for the reviews!


http://reviews.llvm.org/D10766

Files:
  lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
  test/MC/ELF/relax-arith2.s
  test/MC/ELF/relax-arith3.s

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10766.28717.patch
Type: text/x-patch
Size: 7663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150629/dca72676/attachment.bin>


More information about the llvm-commits mailing list