[lld] r241008 - Move llvm_unreachable out of switch to avoid -Wswitch-covered-defualt.

Rui Ueyama ruiu at google.com
Mon Jun 29 14:59:34 PDT 2015


Author: ruiu
Date: Mon Jun 29 16:59:34 2015
New Revision: 241008

URL: http://llvm.org/viewvc/llvm-project?rev=241008&view=rev
Log:
Move llvm_unreachable out of switch to avoid -Wswitch-covered-defualt.

Modified:
    lld/trunk/COFF/Symbols.cpp

Modified: lld/trunk/COFF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Symbols.cpp?rev=241008&r1=241007&r2=241008&view=diff
==============================================================================
--- lld/trunk/COFF/Symbols.cpp (original)
+++ lld/trunk/COFF/Symbols.cpp Mon Jun 29 16:59:34 2015
@@ -129,9 +129,8 @@ int SymbolBody::compare(SymbolBody *Othe
   case DefinedAbsoluteKind:
     // These all simply tie.
     return 0;
-  default:
-    llvm_unreachable("unknown symbol kind");
   }
+  llvm_unreachable("unknown symbol kind");
 }
 
 std::string SymbolBody::getDebugName() {
@@ -163,9 +162,8 @@ uint64_t Defined::getRVA() {
   case LazyKind:
   case UndefinedKind:
     llvm_unreachable("Cannot get the address for an undefined symbol.");
-  default:
-    llvm_unreachable("unknown symbol kind");
   }
+  llvm_unreachable("unknown symbol kind");
 }
 
 uint64_t Defined::getFileOff() {
@@ -188,9 +186,8 @@ uint64_t Defined::getFileOff() {
   case LazyKind:
   case UndefinedKind:
     llvm_unreachable("Cannot get a file offset for an undefined symbol.");
-  default:
-    llvm_unreachable("unknown symbol kind");
   }
+  llvm_unreachable("unknown symbol kind");
 }
 
 ErrorOr<std::unique_ptr<InputFile>> Lazy::getMember() {





More information about the llvm-commits mailing list