[PATCH] [opt] Replace the recursive walk for GC with a worklist algorithm.

[Rui Ueyama]

LGTM. I'm planning to make a change to the resolver which would conflict with this change, so I'd like to see this being landed before starting creating my patch.


================
Comment at: COFF/Symbols.h:130
@@ +129,3 @@
+// Symbols defined via a COFF object file.
+class ObjectFileDefined : public Defined {
+  friend SymbolBody;
----------------
I still want you to rename this class for consistency.

================
Comment at: COFF/Writer.cpp:135
@@ +134,3 @@
+    SectionChunk *SC = Worklist.pop_back_val();
+    assert(SC->isLive() && "We mark as live when pushing onto the worklist!");
+
----------------
So you can write SC->markLive() here only once, no? Then you can remove markLive() from all the other places in this function.

http://reviews.llvm.org/D10790

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/