[llvm] r240771 - Do not ignore projects/LLVMBuild.txt in git repo

Duncan P. N. Exon Smith dexonsmith at apple.com
Mon Jun 29 10:44:19 PDT 2015


> On 2015-Jun-28, at 02:07, Sergey Dmitrouk <sdmitrouk at accesssoftek.com> wrote:
> 
> On Sat, Jun 27, 2015 at 09:24:41AM -0700, Duncan P. N. Exon Smith wrote:
>> 
>>> On 2015 Jun 26, at 03:13, Sergey Dmitrouk <sdmitrouk at accesssoftek.com> wrote:
>>> 
>>> Author: sdmitrouk
>>> Date: Fri Jun 26 05:13:56 2015
>>> New Revision: 240771
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=240771&view=rev
>>> Log:
>>> Do not ignore projects/LLVMBuild.txt in git repo
>>> 
>>> Without explicit exception for the path, it matches projects/* rule.
>>> 
>>> Modified:
>>>   llvm/trunk/.gitignore
>>> 
>>> Modified: llvm/trunk/.gitignore
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/.gitignore?rev=240771&r1=240770&r2=240771&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/.gitignore (original)
>>> +++ llvm/trunk/.gitignore Fri Jun 26 05:13:56 2015
>>> @@ -45,6 +45,7 @@ autoconf/autom4te.cache
>>> # External projects that are tracked independently.
>>> projects/*
>>> !projects/CMakeLists.txt
>>> +!projects/LLVMBuild.txt
>>> !projects/Makefile
>> 
>> Should the `projects/*` rule just be changed to `projects/*/`?
> 
> I don't put anything in that directory and not sure how convenient it
> would be to do not ignore all files directly under it, thus followed
> existing pattern.
> 
> `projects/*/` works too (although I'm not sure since which version of
> git it is supported), in case anyone feels like it's better way of doing
> this.

Seems better to me.  r240973.  If someone complains about old versions of
git (although frankly I doubt this a new feature) we can switch back.



More information about the llvm-commits mailing list