[PATCH] Replace uint64_t representation of Features with FeatureBitset (std::bitset) in a few more places

Ranjeet Singh ranjeet.singh at arm.com
Mon Jun 29 07:21:40 PDT 2015


Hi Michael,

> Extra space here?


Nice spot, I've removed it.

> Are you sure about the "-1"?

> (Then again, I don't understand why the original -1 was there either...)


No, I'm not sure about it, it was inherited from the previous code. I can't find a reason as to why it was there so I've removed it.

Thanks,
Ranjeet


http://reviews.llvm.org/D10542

Files:
  include/llvm/MC/MCTargetAsmParser.h
  lib/MC/MCParser/AsmParser.cpp
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
  lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
  lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  utils/TableGen/AsmMatcherEmitter.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10542.28667.patch
Type: text/x-patch
Size: 37811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150629/a9de7766/attachment.bin>


More information about the llvm-commits mailing list