[PATCH] Do not export gtest library targets or install them for CMake and do not export for Autoconf/Makefile install

Brad King brad.king at kitware.com
Mon Jun 29 07:12:32 PDT 2015


On 06/26/2015 08:13 PM, Dan Liew wrote:
> Unfortunately there are still references to gtest and gtest_main in
> the generated LLVMConfig.cmake when using the Autoconf/Makefile build
> system.
> 
> ```
> set_property(GLOBAL PROPERTY LLVMBUILD_LIB_DEPS_gtest LLVMSupport)
> set_property(GLOBAL PROPERTY LLVMBUILD_LIB_DEPS_gtest_main gtest)
> ```

Try grepping for the implementation and use of the llvm-build option
called "--write-cmake-fragment".  That is responsible for generating
this content in the Autoconf build.

> Could someone please review this before I commit it?

After applying the patch I built with both CMake and Autoconf.
In their install trees there is no mention of gtest in the LLVMConfig
or LLVMExport* files other than in what you quote above.  My app
still builds against either tree.  So:

Acked-by: Brad King <brad.king at kitware.com>

Thanks,
-Brad



More information about the llvm-commits mailing list