[PATCH] [mips][microMIPS] Implement SLL and NOP instructions

Daniel Sanders daniel.sanders at imgtec.com
Mon Jun 29 05:48:13 PDT 2015


LGTM


================
Comment at: lib/Target/Mips/MicroMips32r6InstrFormats.td:267-268
@@ +266,4 @@
+  let Inst{31-26} = 0;
+  let Inst{25-21} = rd;
+  let Inst{20-16} = rt;
+  let Inst{15-11} = shamt;
----------------
dsanders wrote:
> The documentation calls them 'rt' and 'rs' respectively. That doesn't sound right though, 'rd' and 'rt' sound more likely.
I've found out a bit more about this kind of thing and I suggest we leave it as-is for now.

The issue is that MIPS and microMIPS don't always agree on the names since the names are derived from the fields of the encoding table and these two encodings sometimes use different fields. I'm currently thinking of a reasonable way to account for this without making the code ugly.

http://reviews.llvm.org/D10474

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list