[PATCH] Fix test-release.sh to use DESTDIR

Dan Liew dan at su-root.co.uk
Fri Jun 26 18:22:54 PDT 2015


Hi,

This patch tries to fix the test-release.sh script which looks like
it's used for creating the final release binaries.

The problem is that --prefix was set to a temporary build directory
which then shows up in the final binaries and build files. In
particular the installed LLVMConfig.cmake and LLVMExports.cmake files
contain these paths making them completely broken.

You can observe this if you take a look at the contents of the binary
tarballs (Ubuntu tarballs) on LLVM's release page for LLVM 3.5.

For the LLVM 3.6.x tarballs the CMake files are completely missing
(Ubuntu tarballs). I don't understand why, the test-release.sh script
doesn't appear to do anything to remove these files explicitly. What
happened here?

The way this is normally handled is that --prefix is set to where it
is intended for the files to be installed and DESTDIR is set when
running ``make install`` to have files be installed elsewhere in
preparation for tarballing.

This patch sets ``--prefix`` to ``/usr/local`` by default (although is
can be changed using a command line option to the script) and uses
DESTDIR to install the files elsewhere.

``/usr/local`` seems like a sensible default to me that should avoid
where Linux package managers typically install their packages and I
think this is also used on OSX too.

Thanks,
Dan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_release_use_destdir.patch
Type: text/x-patch
Size: 5373 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150626/fbf01415/attachment.bin>


More information about the llvm-commits mailing list