[PATCH] [LLD] COFF: Remove dead code.

Rui Ueyama ruiu at google.com
Fri Jun 26 15:08:13 PDT 2015


Hi pcc,

LLD got a support of the map file, so this function seems useless now.

http://reviews.llvm.org/D10780

Files:
  COFF/SymbolTable.cpp
  COFF/SymbolTable.h

Index: COFF/SymbolTable.cpp
===================================================================
--- COFF/SymbolTable.cpp
+++ COFF/SymbolTable.cpp
@@ -228,15 +228,6 @@
   return std::error_code();
 }
 
-void SymbolTable::dump() {
-  for (auto &P : Symtab) {
-    Symbol *Ref = P.second;
-    if (auto *Body = dyn_cast<Defined>(Ref->Body))
-      llvm::dbgs() << Twine::utohexstr(Config->ImageBase + Body->getRVA())
-                   << " " << Body->getName() << "\n";
-  }
-}
-
 void SymbolTable::printMap(llvm::raw_ostream &OS) {
   for (ObjectFile *File : ObjectFiles) {
     OS << File->getShortName() << ":\n";
Index: COFF/SymbolTable.h
===================================================================
--- COFF/SymbolTable.h
+++ COFF/SymbolTable.h
@@ -60,9 +60,6 @@
   // entry point name.
   ErrorOr<StringRef> findDefaultEntry();
 
-  // Dump contents of the symbol table to stderr.
-  void dump();
-
   // Print a layout map to OS.
   void printMap(llvm::raw_ostream &OS);

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10780.28603.patch
Type: text/x-patch
Size: 986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150626/abcfe32b/attachment.bin>


More information about the llvm-commits mailing list